Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22865 )

Change subject: IMPALA-13869: Support for 'hive.sql.query' property for Hive 
JDBC tables
......................................................................


Patch Set 3:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22865/3/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java
File fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java:

http://gerrit.cloudera.org:8080/#/c/22865/3/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@307
PS3, Line 307:     if (!Strings.isNullOrEmpty(tableName)) { // Ensure 'table' 
property is not null or empty
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I039fcc1e008233a3eeed8d09554195fdb8c8706b
Gerrit-Change-Number: 22865
Gerrit-PatchSet: 3
Gerrit-Owner: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Fri, 13 Jun 2025 21:20:58 +0000
Gerrit-HasComments: Yes

Reply via email to