Jason Fehr has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/23418 )
Change subject: IMPALA-14372: Output OpenTelemetry SDK Logs to Impala Logs ...................................................................... IMPALA-14372: Output OpenTelemetry SDK Logs to Impala Logs Emits log messages from the OpenTelemetry SDK to the Impalad INFO, WARNING, and ERROR logs. Previously, these SDK log messages were dropped. SDK DEBUG level log messages are also emitted to the Impalad INFO log when the vlog level is greater than or equal to 2. Removes the 'otel_debug' startup flag and sets the OpenTelemetry SDK log level based on the overall vlog level. When a trace is successfully sent to the OpenTelemetry collector, zero log lines are generated. When a trace cannot be sent, local testing showed 12 lines with a total size around 3k were written between the impalad.ERROR and impalad.WARNING log files. The request body is not included in these log messages unless the vlog level is greater than or equal to 2 thus log message size will not grow or shrink based on the size of the trace(s). This patch also removes the completely useless 'LoggingInstrumentation' class. Previously, the 'otel_debug' flag caused this class to log messages, but those messages provided no insightful information. Generated-by: Github Copilot (Claude Sonnet 3.7) Change-Id: I41aba21f46233e6430eede9606be1e791071717a --- M be/src/observe/CMakeLists.txt M be/src/observe/otel-flags.cc D be/src/observe/otel-instrument.h A be/src/observe/otel-log-handler.cc A be/src/observe/otel-log-handler.h M be/src/observe/otel.cc M tests/custom_cluster/test_otel_trace.py 7 files changed, 132 insertions(+), 87 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/23418/4 -- To view, visit http://gerrit.cloudera.org:8080/23418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I41aba21f46233e6430eede9606be1e791071717a Gerrit-Change-Number: 23418 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Fehr <[email protected]>
