Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23418 )
Change subject: IMPALA-14372: Output OpenTelemetry SDK Logs to Impala Logs ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-log-handler.cc File be/src/observe/otel-log-handler.cc: http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-log-handler.cc@23 PS4, Line 23: #include <opentelemetry/nostd/variant.h> Why is this unlikely? http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-log-handler.cc@27 PS4, Line 27: We don't need StringStreamPop here, a regular stringstream is sufficient. Is there a Substitute(...) option that would work for this? http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel.cc File be/src/observe/otel.cc: http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel.cc@303 PS4, Line 303: GlobalLogHandler::SetLogLevel(VLOG_IS_ON(2) ? LogLevel::Debug : LogLevel::Info); > What happen if I change log level in WebUI? will this also change? Not via this, it would need to be implemented in webserver.cc. I think that would be worth adding. -- To view, visit http://gerrit.cloudera.org:8080/23418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41aba21f46233e6430eede9606be1e791071717a Gerrit-Change-Number: 23418 Gerrit-PatchSet: 5 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 18 Sep 2025 00:00:31 +0000 Gerrit-HasComments: Yes
