Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23418 )
Change subject: IMPALA-14372: Output OpenTelemetry SDK Logs to Impala Logs ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-flags.cc File be/src/observe/otel-flags.cc: http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-flags.cc@a29 PS4, Line 29: nit: I am usually cautious about removing existing flag. But since this one is pretty new, immediate removal is probably fine. Please check other otel flags. If they are not too significant, consider making them hidden. http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-log-handler.h File be/src/observe/otel-log-handler.h: http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-log-handler.h@22 PS4, Line 22: class OtelLogHandler : public opentelemetry::sdk::common::internal_log::LogHandler { nit: some class comment will be nice. http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel.cc File be/src/observe/otel.cc: http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel.cc@303 PS4, Line 303: GlobalLogHandler::SetLogLevel(VLOG_IS_ON(2) ? LogLevel::Debug : LogLevel::Info); What happen if I change log level in WebUI? will this also change? -- To view, visit http://gerrit.cloudera.org:8080/23418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41aba21f46233e6430eede9606be1e791071717a Gerrit-Change-Number: 23418 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 17 Sep 2025 22:49:28 +0000 Gerrit-HasComments: Yes
