Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23536 )
Change subject: IMPALA-13066: Extend SHOW CREATE TABLE to include stats and partitions ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/23536/1/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/23536/1/common/thrift/Frontend.thrift@526 PS1, Line 526: 15: optional TShowCreateTableParams show_create_table_params Changing type of existing thrift field is a breaking change. Perhaps you can move the with_stats field here into TShowFunctionsParams as the 20th field? 20: optional bool with_stats http://gerrit.cloudera.org:8080/#/c/23536/1/tests/metadata/test_show_create_table.py File tests/metadata/test_show_create_table.py: http://gerrit.cloudera.org:8080/#/c/23536/1/tests/metadata/test_show_create_table.py@280 PS1, Line 280: ): nit: line this up to L279 -- To view, visit http://gerrit.cloudera.org:8080/23536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87950ae9d9bb73cb2a435cf5bcad076df1570dc2 Gerrit-Change-Number: 23536 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 14 Oct 2025 14:42:37 +0000 Gerrit-HasComments: Yes
