Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23536 )
Change subject: IMPALA-13066: Extend SHOW CREATE TABLE to include stats and partitions ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23536/3/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/23536/3/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@571 PS3, Line 571: List<? extends FeFsPartition> partitions = new ArrayList<>(fsTable.loadAllPartitions()); : partitions.sort(HdfsPartition.KV_COMPARATOR); : for (FeFsPartition p : partitions) { This can have potential scale issue if a table has thousands of partitions, potentially blowing up CatalogD or local catalog. I recommend skipping the per-partition ALTER for now, just to be safe. http://gerrit.cloudera.org:8080/#/c/23536/3/tests/metadata/test_show_create_table.py File tests/metadata/test_show_create_table.py: http://gerrit.cloudera.org:8080/#/c/23536/3/tests/metadata/test_show_create_table.py@123 PS3, Line 123: @pytest.mark.parametrize("fmt", ["PARQUET", "TEXTFILE"]) : def test_show_create_table_with_stats_matrix(self, vector, unique_database, cfg, fmt): Is it possible to follow existing tests in using __run_show_create_table_test_case and .test file? See ./testdata/workloads/functional-query/queries/QueryTest/show-create-table.test for example. -- To view, visit http://gerrit.cloudera.org:8080/23536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87950ae9d9bb73cb2a435cf5bcad076df1570dc2 Gerrit-Change-Number: 23536 Gerrit-PatchSet: 3 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 15 Oct 2025 17:34:35 +0000 Gerrit-HasComments: Yes
