Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23536 )
Change subject: IMPALA-13066: Extend SHOW CREATE TABLE to include stats and partitions ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/23536/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23536/4//COMMIT_MSG@11 PS4, Line 11: * Emit ALTER … SET TBLPROPERTIES for table-level stats (numRows, > This is stale and can be removed. Done http://gerrit.cloudera.org:8080/#/c/23536/4/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/23536/4/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@573 PS4, Line 573: > This is probably not always true/exist, and should be checked against the a Done http://gerrit.cloudera.org:8080/#/c/23536/5/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/23536/5/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@626 PS5, Line 626: private static void filterInternalTblPropertiesForStats( : Map<String, String> props, FeTable table, : org.apache.hadoop.hive.metastore.api.Table msTbl) { Is it possible to unify this removal with similar routine done in ToSqlUtils.getCreateTableSql() ? -- To view, visit http://gerrit.cloudera.org:8080/23536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87950ae9d9bb73cb2a435cf5bcad076df1570dc2 Gerrit-Change-Number: 23536 Gerrit-PatchSet: 5 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 17 Oct 2025 19:18:53 +0000 Gerrit-HasComments: Yes
