Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23536 )
Change subject: IMPALA-13066: Extend SHOW CREATE TABLE to include stats and partitions ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/23536/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23536/4//COMMIT_MSG@11 PS4, Line 11: * Emit ALTER … ADD PARTITION … ; clauses for existing partitions This is stale and can be removed. http://gerrit.cloudera.org:8080/#/c/23536/4/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/23536/4/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@573 PS4, Line 573: 'STATS_GENERATED_VIA_STATS_TASK'='true' This is probably not always true/exist, and should be checked against the actual key-value in table.getMetaStoreTable().getParameters(). Should this show all table properties instead? -- To view, visit http://gerrit.cloudera.org:8080/23536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87950ae9d9bb73cb2a435cf5bcad076df1570dc2 Gerrit-Change-Number: 23536 Gerrit-PatchSet: 4 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 16 Oct 2025 18:34:22 +0000 Gerrit-HasComments: Yes
