Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10571 )

Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is 
enabled
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java
File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java:

http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@117
PS5, Line 117:     stmt.sqlString_ = null;
> So removing stmt.sqlString_ = null breaks this test.
- I think the test you mentioned is broken because tableRefTosql() is not 
called with rewritten in TableRef.java. See my comment there.
- I don't understand what your statement about between is for. I'm not 
suggesting to turn it off. I think we need to change the test cases and replace 
those "<= x and >= y" with the original "BETWEEN" in the expected strings of 
those cases.


http://gerrit.cloudera.org:8080/#/c/10571/10/fe/src/main/java/org/apache/impala/analysis/TableRef.java
File fe/src/main/java/org/apache/impala/analysis/TableRef.java:

http://gerrit.cloudera.org:8080/#/c/10571/10/fe/src/main/java/org/apache/impala/analysis/TableRef.java@593
PS10, Line 593:
tableRefToSql(rewritten)



--
To view, visit http://gerrit.cloudera.org:8080/10571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53
Gerrit-Change-Number: 10571
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jun 2018 00:06:25 +0000
Gerrit-HasComments: Yes

Reply via email to