Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 )
Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@117 PS5, Line 117: stmt.sqlString_ = null; > Sorry for being unclear. What I was trying to say is that the between behav So removing stmt.sqlString_ = null breaks this test. SQL: select * from functional.alltypes where id = (select 1 + 1)) a Expected :SELECT * FROM (SELECT * FROM functional.alltypes LEFT SEMI JOIN (SELECT 2) `$a$1` (`$c$1`) ON id = `$a$1`.`$c$1`) a Actual: SELECT * FROM (SELECT * FROM functional.alltypes LEFT SEMI JOIN (SELECT 1 + 1) `$a$1` (`$c$1`) ON id = `$a$1`.`$c$1`) a For between predicates, we have a rewritten rule that can't be turned off: https://github.com/apache/impala/blob/06fe3210509424cf50fdd3cc919466a1ce6bc842/fe/src/main/java/org/apache/impala/analysis/Analyzer.java#L322 -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 10 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 12 Jun 2018 02:24:54 +0000 Gerrit-HasComments: Yes
