Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 )
Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/10571/8/fe/src/main/java/org/apache/impala/analysis/FromClause.java File fe/src/main/java/org/apache/impala/analysis/FromClause.java: http://gerrit.cloudera.org:8080/#/c/10571/8/fe/src/main/java/org/apache/impala/analysis/FromClause.java@129 PS8, Line 129: > Call toSqlString(rewritten)? Done http://gerrit.cloudera.org:8080/#/c/10571/8/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/10571/8/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@973 PS8, Line 973: // Where clause > Call toSqlString(rewritten) directly? Done http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/10571/5/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@117 PS5, Line 117: stmt.sqlString_ = null; > I tried removing it and it broke AnalyzeSubqueriesTest TestExistsSubqueries Although I agree that "between y and x" is essentially the same as "<= x and >= y", Isn't it better if the error messages mimic the user queries (with the exception of case sensitivity and fully qualified names) to not confuse them? Let me know what you think? http://gerrit.cloudera.org:8080/#/c/10571/8/fe/src/main/java/org/apache/impala/analysis/TableRef.java File fe/src/main/java/org/apache/impala/analysis/TableRef.java: http://gerrit.cloudera.org:8080/#/c/10571/8/fe/src/main/java/org/apache/impala/analysis/TableRef.java@575 PS8, Line 575: protected String tableRefToSql(boolean rewritten) { > Why this? The idea is for InlineViewRef to override it. But I can also simplify it by having tableRefToSql(boolean rewritten) and override it in InlineViewRef. -- To view, visit http://gerrit.cloudera.org:8080/10571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53 Gerrit-Change-Number: 10571 Gerrit-PatchSet: 10 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 12 Jun 2018 00:45:57 +0000 Gerrit-HasComments: Yes
