Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10571 )

Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is 
enabled
......................................................................


Patch Set 12:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10571/11/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java:

http://gerrit.cloudera.org:8080/#/c/10571/11/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@941
PS11, Line 941:     return toSql(false);
> Remove because the implementation is the same as in StatementBase
Done


http://gerrit.cloudera.org:8080/#/c/10571/11/fe/src/main/java/org/apache/impala/analysis/UnionStmt.java
File fe/src/main/java/org/apache/impala/analysis/UnionStmt.java:

http://gerrit.cloudera.org:8080/#/c/10571/11/fe/src/main/java/org/apache/impala/analysis/UnionStmt.java@554
PS11, Line 554:   public String toSql(boolean rewritten) {
> Remove because the implementation is the same as in StatementBase
Done



--
To view, visit http://gerrit.cloudera.org:8080/10571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab58b0cc865135d261dd4a7f72be130f2e7bde53
Gerrit-Change-Number: 10571
Gerrit-PatchSet: 12
Gerrit-Owner: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Tianyi Wang <[email protected]>
Gerrit-Reviewer: Vuk Ercegovac <[email protected]>
Gerrit-Comment-Date: Wed, 13 Jun 2018 20:41:38 +0000
Gerrit-HasComments: Yes

Reply via email to