Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java: http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@a178 PS2, Line 178: Side note: did this already work for creating a non-Iceberg table from an Iceberg table? Do we have test coverage for that? This guard didn't prevent it. http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4705 PS2, Line 4705: new ArrayList<>(), // No primary keys for non-Iceberg source What if the source is a Kudu table? http://gerrit.cloudera.org:8080/#/c/23733/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test: http://gerrit.cloudera.org:8080/#/c/23733/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test@169 PS2, Line 169: # Note: Impala doesn't support INSERT into tables with complex types, We can use HIVE_QUERY sections to run tests in beeline, however we then have to restrict the test with @SkipIfFS.hive. -- To view, visit http://gerrit.cloudera.org:8080/23733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e Gerrit-Change-Number: 23733 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 09 Dec 2025 23:19:58 +0000 Gerrit-HasComments: Yes
