Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Allow CREATE TABLE LIKE to create Iceberg tables ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/23733/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23733/2//COMMIT_MSG@9 PS2, Line 9: Add support for cloning non-Iceberg tables into Iceberg tables. : Enable CREATE TABLE LIKE <src> STORED BY ICEBERG for all schemas. : Preserve column types, nullability, comments, and table properties. : Support both partitioned and external source tables in LIKE flows. : Preserve partition specs and identity transforms when present. : This improves Hive 3.1 test migration and cross-engine workflows. : nit: IMO it's weird that all sentences are one-liners, some feels incomplete to me. http://gerrit.cloudera.org:8080/#/c/23733/2/docs/topics/impala_iceberg.xml File docs/topics/impala_iceberg.xml: http://gerrit.cloudera.org:8080/#/c/23733/2/docs/topics/impala_iceberg.xml@972 PS2, Line 972: CREATE TABLE new_ice_tbl LIKE orig_ice_tbl STORED BY ICEBERG; What happens if STORED BY ICEBERG is missing? http://gerrit.cloudera.org:8080/#/c/23733/2/docs/topics/impala_iceberg.xml@978 PS2, Line 978: <codeph>IcebergSchemaConverter</codeph> I don't think it makes sense to mention an Impala Java class in the documentation. http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java: http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@178 PS2, Line 178: JDBC tables and Paimon -- To view, visit http://gerrit.cloudera.org:8080/23733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e Gerrit-Change-Number: 23733 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 10 Dec 2025 13:54:15 +0000 Gerrit-HasComments: Yes
