Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23733 )
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from non-Iceberg sources ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/23733/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23733/2//COMMIT_MSG@9 PS2, Line 9: This patch enables creating Iceberg tables from non-Iceberg source tables : using the CREATE TABLE LIKE syntax with STORED BY ICEBERG. Previously, : Impala only allowed cloning between Iceberg tables due to concerns about : type conversion. This limitation prevented users from easily migrating : existing tables to Iceberg format, which is particularly important for : Apache Hive 3.1 compatibility where CTAS with STORED BY ICEBERG is not : > nit: IMO it's weird that all sentences are one-liners, some feels incomplet Done http://gerrit.cloudera.org:8080/#/c/23733/2/docs/topics/impala_iceberg.xml File docs/topics/impala_iceberg.xml: http://gerrit.cloudera.org:8080/#/c/23733/2/docs/topics/impala_iceberg.xml@972 PS2, Line 972: </p> > What happens if STORED BY ICEBERG is missing? Done http://gerrit.cloudera.org:8080/#/c/23733/2/docs/topics/impala_iceberg.xml@978 PS2, Line 978: , e.g. Trino, also write the NDV as a p > I don't think it makes sense to mention an Impala Java class in the documen Done http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java: http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@a178 PS2, Line 178: > Side note: did this already work for creating a non-Iceberg table from an I Creating non-Iceberg tables from Iceberg sources already works http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@178 PS2, Line 178: non-Iceber > and Paimon Done http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/23733/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4705 PS2, Line 4705: // Use empty table properties since we're creating from a non-Iceberg source > What if the source is a Kudu table? Nice catch, CreateTableLikeStmt.validateCreateKuduTableParams() should reject Kudu -> Iceberg during analysis phase. Added defensive Preconditions.checkState() to fail if we somehow reach the code http://gerrit.cloudera.org:8080/#/c/23733/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test: http://gerrit.cloudera.org:8080/#/c/23733/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test@169 PS2, Line 169: CREATE TABLE complex_ice LIKE functional_parquet.complextypestbl STORED BY ICEBERG; > We can use HIVE_QUERY sections to run tests in beeline, however we then hav Done -- To view, visit http://gerrit.cloudera.org:8080/23733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e Gerrit-Change-Number: 23733 Gerrit-PatchSet: 3 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 12 Dec 2025 05:39:48 +0000 Gerrit-HasComments: Yes
