Hello Quanlong Huang, Riza Suminto, Zoltan Borok-Nagy, Daniel Vanko, Michael
Smith, Csaba Ringhofer, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23733
to look at the new patch set (#3).
Change subject: IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from
non-Iceberg sources
......................................................................
IMPALA-13299: Support CREATE TABLE LIKE for Iceberg from non-Iceberg sources
This patch enables creating Iceberg tables from non-Iceberg source tables
using the CREATE TABLE LIKE syntax with STORED BY ICEBERG. Previously,
Impala only allowed cloning between Iceberg tables due to concerns about
type conversion. This limitation prevented users from easily migrating
existing tables to Iceberg format, which is particularly important for
Apache Hive 3.1 compatibility where CTAS with STORED BY ICEBERG is not
supported.
Key implementation details:
- Removed the restriction in CreateTableLikeStmt that blocked creating
Iceberg tables from non-Iceberg sources.
- Added conversion logic in CatalogOpExecutor to handle non-Iceberg to
Iceberg table cloning. This includes proper column ordering (data
columns first, then partition columns).
- Created helper method createIdentityPartitionSpec() to convert HMS
partition keys to Iceberg identity partition transforms.
Testing:
- Created comprehensive end-to-end tests in iceberg-create-table-like-
non-iceberg.test covering schema conversion with various data types,
partition transform verification, complex types (STRUCT, ARRAY, MAP),
and data insertion validation.
Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
---
M docs/topics/impala_iceberg.xml
M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
A
testdata/workloads/functional-query/queries/QueryTest/iceberg-create-table-like-non-iceberg.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M tests/query_test/test_iceberg.py
7 files changed, 383 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/23733/3
--
To view, visit http://gerrit.cloudera.org:8080/23733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id162f217e49e9f396419b09815b92eb7f351881e
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
