Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23905 )
Change subject: IMPALA-12844 Support setting DBPROPERTIES ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/23905/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23905/8//COMMIT_MSG@7 PS8, Line 7: IMPALA-12844 Support setting DBPROPERTIES nit: we usually put ':' after jira id http://gerrit.cloudera.org:8080/#/c/23905/8//COMMIT_MSG@10 PS8, Line 10: CREATE TABLE CREATE DATABASE http://gerrit.cloudera.org:8080/#/c/23905/8//COMMIT_MSG@13 PS8, Line 13: either at database creation or for already existing databases. one more that could be tested is the handling of impala.disableHmsSync If you search for this property, you'll see several HMS event processor related test that changes it (using Hive) Alter database events are handled here: https://github.com/apache/impala/blob/8ff71d61e53fbb2690f8e5a60002f108a5f17430/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java#L2632 an idea for checking if they take effect when run in Impala is to run case 2 and 3 twice in the following test, once doing the alter db in Hive, once in Impala https://github.com/apache/impala/blob/8ff71d61e53fbb2690f8e5a60002f108a5f17430/tests/custom_cluster/test_events_custom_configs.py#L1909 http://gerrit.cloudera.org:8080/#/c/23905/7/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/23905/7/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@2685 PS7, Line 2685: authorize("alter database functional set dbproperties('a'='b')") : .ok(onServer(TPrivilegeLevel.ALL)) : .ok(onServer(TPrivilegeLevel.OWNER)) : .ok(onServer(TPrivilegeLevel.ALTER)) : .ok(onDatabase("functional", TPrivilegeLevel.ALL)) : .ok(onDatabase("functional", TPrivilegeLevel.OWNER)) : .ok(onDatabase("functional", TPrivilegeLevel.ALTER)) : .error(alterError("functional")) : .error(alterError("functional"), onServer(allExcept( : TPrivilegeLevel.ALL, TPrivilegeLevel.OWNER, : TPrivilegeLevel.ALTER))) : .error(alterError("functional"), onDatabase("functional", : allExcept(TPrivilegeLevel.ALL, TPrivilegeLevel.OWNER, : TPrivilegeLevel.ALTER))); : : authorize("alter database functional set dbproperties('a'='b')") : .ok(onServer(TPrivilegeLevel.values())) : .ok(onDatabase("functional", TPrivilegeLevel.values())); : : // Database does not exist. > Added ALTER privilege for dbproperties tests, but now I don't see a clear w ack -- To view, visit http://gerrit.cloudera.org:8080/23905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I628c7bed4f0c39aed7f5f4ffea52421caf501933 Gerrit-Change-Number: 23905 Gerrit-PatchSet: 8 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 03 Feb 2026 15:14:20 +0000 Gerrit-HasComments: Yes
