Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/23905 )
Change subject: IMPALA-12844: Support setting DBPROPERTIES ...................................................................... Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/23905/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23905/8//COMMIT_MSG@7 PS8, Line 7: IMPALA-12844: Support setting DBPROPERTIES > nit: we usually put ':' after jira id Done http://gerrit.cloudera.org:8080/#/c/23905/8//COMMIT_MSG@10 PS8, Line 10: CREATE DATAB > CREATE DATABASE Done http://gerrit.cloudera.org:8080/#/c/23905/8//COMMIT_MSG@13 PS8, Line 13: either at database creation or for already existing databases. > one more that could be tested is the handling of impala.disableHmsSync Done http://gerrit.cloudera.org:8080/#/c/23905/8/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/23905/8/common/thrift/JniCatalog.thrift@92 PS8, Line 92: // The type of ALTER DATABASE > This doesn't seem to be used anywhere. Done http://gerrit.cloudera.org:8080/#/c/23905/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/23905/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@a8420 PS8, Line 8420: : : : > This got removed by mistake in the refactor. Done http://gerrit.cloudera.org:8080/#/c/23905/8/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/23905/8/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@335 PS8, Line 335: > Could we add a very small test case like the following in testPrivilegeRequ Done -- To view, visit http://gerrit.cloudera.org:8080/23905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I628c7bed4f0c39aed7f5f4ffea52421caf501933 Gerrit-Change-Number: 23905 Gerrit-PatchSet: 9 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 04 Feb 2026 15:17:39 +0000 Gerrit-HasComments: Yes
