Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23905 )
Change subject: IMPALA-12844 Support setting DBPROPERTIES ...................................................................... Patch Set 8: (2 comments) Thanks for addressing my previous comments on patch set 7! I only left one small additional suggestion in AuthorizationStmtTest.java. http://gerrit.cloudera.org:8080/#/c/23905/7/fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbPropertiesStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbPropertiesStmt.java: http://gerrit.cloudera.org:8080/#/c/23905/7/fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbPropertiesStmt.java@51 PS7, Line 51: tDb > Thank you for the detailed information. Done http://gerrit.cloudera.org:8080/#/c/23905/8/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/23905/8/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@335 PS8, Line 335: } Could we add a very small test case like the following in testPrivilegeRequests() to show that a privilege request for "functional" will be registered? This test does not check the type of operation (e.g., ALTER or SELECT) but it is still better than nothing. expectedAuthorizables = Sets.newHashSet("functional"); verifyPrivilegeReqs("alter database functional set dbproperties ('a'='b')", expectedAuthorizables); -- To view, visit http://gerrit.cloudera.org:8080/23905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I628c7bed4f0c39aed7f5f4ffea52421caf501933 Gerrit-Change-Number: 23905 Gerrit-PatchSet: 8 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 03 Feb 2026 17:55:27 +0000 Gerrit-HasComments: Yes
