Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23942 )
Change subject: IMPALA-14230: Add catch-up mode for event processing ...................................................................... Patch Set 3: (9 comments) Thanks for the review. This PS addresses part of the review comments. I will handle the remaining items in a follow-up http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@961 PS1, Line 961: tableWriteIds_.stream() > We need to handle CommitTxnEvent as well. 'tableNames_' are populated from Added a new logic here. http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1158 PS1, Line 1158: isPartitioned_ = isPartitioned; > Missed to handle for PseudoCommitTxnEvent. Done http://gerrit.cloudera.org:8080/#/c/23942/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/23942/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@999 PS2, Line 999: + "an invalidate metadata command to reset event processor.", txnId_), e); > line too long (98 > 90) Done http://gerrit.cloudera.org:8080/#/c/23942/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1015 PS2, Line 1015: > line too long (98 > 90) Done http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1205 PS1, Line 1205: public static abstract class MetastoreTableEvent extends MetastoreEvent { > nit: Let's move this after the constructor on L1227. Done http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@3111 PS1, Line 3111: > Self-event detection for partition level events could be stuck in waiting f Done http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@3711 PS1, Line 3711: tableWriteIds_ = catalog_.removeWriteIds(txnId_); > Missed to handle for AbortTxnEvent. Done http://gerrit.cloudera.org:8080/#/c/23942/1/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/23942/1/tests/custom_cluster/test_events_custom_configs.py@680 PS1, Line 680: "--enable_hierarchical_event_processing=false " > Let's disable hierarchical event processing in the test since this feature Done http://gerrit.cloudera.org:8080/#/c/23942/1/tests/custom_cluster/test_events_custom_configs.py@709 PS1, Line 709: assert 'p=3' in res.get_data() > We'd better add more tests to cover other event types that support this mod Added a CommitTxnEvent related test, will see to add more. -- To view, visit http://gerrit.cloudera.org:8080/23942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib906c06346d5d3159999eeac632e1318bc060065 Gerrit-Change-Number: 23942 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 11 Feb 2026 03:56:38 +0000 Gerrit-HasComments: Yes
