Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23942 )
Change subject: IMPALA-14230: Add catch-up mode for event processing ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1205 PS1, Line 1205: protected boolean handleIfInCatchUpMode() { nit: Let's move this after the constructor on L1227. http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1217 PS1, Line 1217: getFullyQualifiedTblName(), lag); Let's also update the EVENTS_SKIPPED_METRIC and the test can verify it. http://gerrit.cloudera.org:8080/#/c/23942/1/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/23942/1/tests/custom_cluster/test_events_custom_configs.py@680 PS1, Line 680: "--debug_actions=catalogd_event_processing_delay:SLEEP@3500", Let's disable hierarchical event processing in the test since this feature is mostly needed by the single-threaded mode. --enable_hierarchical_event_processing=false -- To view, visit http://gerrit.cloudera.org:8080/23942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib906c06346d5d3159999eeac632e1318bc060065 Gerrit-Change-Number: 23942 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 09 Feb 2026 08:15:12 +0000 Gerrit-HasComments: Yes
