Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23942 )
Change subject: IMPALA-14230: Add catch-up mode for event processing ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1210 PS1, Line 1210: * derived events are processed. > May be it is good to avoid this call if the table is already IncompleteTabl Added a mode skipIfIncomplete in invalidateTableIfExists() to skip the IncompleteTable. http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1217 PS1, Line 1217: } > Let's also update the EVENTS_SKIPPED_METRIC and the test can verify it. Done http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1954 PS1, Line 1954: this); > How about we call this method in org.apache.impala.catalog.events.Metastore Some event types like CREATE/DROP TABLE are fast and safe to process directly, and catch-up mode is not necessarily needed, I’d prefer to keep the calls in the specific table event types similar to isSelfEvent() checks http://gerrit.cloudera.org:8080/#/c/23942/1/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/23942/1/tests/custom_cluster/test_events_custom_configs.py@709 PS1, Line 709: assert 'p=1' in res.get_data() > Added a CommitTxnEvent related test, will see to add more. Added one more partition related test. -- To view, visit http://gerrit.cloudera.org:8080/23942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib906c06346d5d3159999eeac632e1318bc060065 Gerrit-Change-Number: 23942 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 18 Feb 2026 22:14:07 +0000 Gerrit-HasComments: Yes
