Steve Carlin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24075 )

Change subject: IMPALA-14789: Modify some tests for Calcite planner
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24075/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test
File 
testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test:

http://gerrit.cloudera.org:8080/#/c/24075/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test@334
PS3, Line 334: # Calcite plan does not have union nodes
> Ack...will add this soon, wanted to post other comments but signal that I s
Done


http://gerrit.cloudera.org:8080/#/c/24075/1/testdata/workloads/functional-query/queries/QueryTest/subquery.test
File testdata/workloads/functional-query/queries/QueryTest/subquery.test:

http://gerrit.cloudera.org:8080/#/c/24075/1/testdata/workloads/functional-query/queries/QueryTest/subquery.test@1108
PS1, Line 1108: ---- CALCITE_PLANNER_CATCH: ANY_OF
> So before the Calcite planner existed, there is no reason at all to support
Fixed the problem in impala_test_suite, so I removed the ANY_OF.

Note though:  If you try to test this as/is, it still won't work.  It needs to 
either be

a) on top of https://gerrit.cloudera.org/#/c/23930/

b) Temporarily change the file_format to "text" instead of "parquet" for this 
test.



--
To view, visit http://gerrit.cloudera.org:8080/24075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc0982fe2ece5323cfc77ee8aee4c55bac6062f
Gerrit-Change-Number: 24075
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Wed, 18 Mar 2026 14:24:27 +0000
Gerrit-HasComments: Yes

Reply via email to