Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24075 )
Change subject: IMPALA-14789: Modify some tests for Calcite planner ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/24075/3/testdata/workloads/functional-query/queries/QueryTest/explain-level0.test File testdata/workloads/functional-query/queries/QueryTest/explain-level0.test: http://gerrit.cloudera.org:8080/#/c/24075/3/testdata/workloads/functional-query/queries/QueryTest/explain-level0.test@37 PS3, Line 37: # Calcite planner has no rewrite, so this section is blank What happens then? Calcite planner fails? Or it produces a plan, and you're just not checking for any details of the plan? http://gerrit.cloudera.org:8080/#/c/24075/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test File testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test: http://gerrit.cloudera.org:8080/#/c/24075/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test@334 PS3, Line 334: # Calcite plan does not have union nodes Why not check for something else in the profile? http://gerrit.cloudera.org:8080/#/c/24075/1/testdata/workloads/functional-query/queries/QueryTest/subquery.test File testdata/workloads/functional-query/queries/QueryTest/subquery.test: http://gerrit.cloudera.org:8080/#/c/24075/1/testdata/workloads/functional-query/queries/QueryTest/subquery.test@1108 PS1, Line 1108: ---- CALCITE_PLANNER_CATCH: ANY_OF > Sigh, I cheated a bit here... I'm still confused what it's doing that's different. Why didn't the prior behavior work with CALCITE_PLANNER_CATCH: __NO_ERROR__? -- To view, visit http://gerrit.cloudera.org:8080/24075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cc0982fe2ece5323cfc77ee8aee4c55bac6062f Gerrit-Change-Number: 24075 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 17 Mar 2026 18:46:12 +0000 Gerrit-HasComments: Yes
