Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24248 )
Change subject: IMPALA-14847: Add diagnostics for large ExecQueryFInstances RPCs ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24248/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24248/2//COMMIT_MSG@15 PS2, Line 15: 1. It prints a warning about ExecQueryFInstances RPCs that > Maybe it's OK for warnings/errors. We already have cancellation logs per ba I'm changing this to have a short summary for the query then detail about the 3 largest RPCs. That should avoid spamming the logs for systems with lots of executors. Is the 25MB threshold ok or should it be something else? http://gerrit.cloudera.org:8080/#/c/24248/2/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/24248/2/be/src/runtime/coordinator-backend-state.cc@367 PS2, Line 367: LOG(WARNING) << "Large ExecQueryFInstances RPC: Total: " > Maybe also print the host to be able to detect outliers? Added the host information to this message -- To view, visit http://gerrit.cloudera.org:8080/24248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10e1fd50bf2fec2b8969585f7fcec2ca2487e181 Gerrit-Change-Number: 24248 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 07 May 2026 06:03:12 +0000 Gerrit-HasComments: Yes
