Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 6: Code-Review+1 (9 comments) http://gerrit.cloudera.org:8080/#/c/24284/4/be/src/service/query-profile-ai-analysis.cc File be/src/service/query-profile-ai-analysis.cc: http://gerrit.cloudera.org:8080/#/c/24284/4/be/src/service/query-profile-ai-analysis.cc@53 PS4, Line 53: static constexpr size_t MAX_TOOL_RESULT_CHARS = 100000; > Done Done http://gerrit.cloudera.org:8080/#/c/24284/4/be/src/service/query-profile-ai-analysis.cc@55 PS4, Line 55: static const char* SYSTEM_INSTRUCTION = > Done Done http://gerrit.cloudera.org:8080/#/c/24284/4/be/src/service/query-profile-ai-analysis.cc@94 PS4, Line 94: "function": { > Removed newlines and now using a raw string literal Done http://gerrit.cloudera.org:8080/#/c/24284/4/be/src/service/query-profile-ai-analysis.cc@294 PS4, Line 294: string tool_call_id; > Done Done http://gerrit.cloudera.org:8080/#/c/24284/4/be/src/service/query-profile-ai-analysis.cc@301 PS4, Line 301: if (tool_json->size() <= MAX_TOOL_RESULT_CHARS) return; : boost::algorithm::erase_tail(tool_json, : tool_json->size() - MAX_TOOL_RESULT_CHARS); : tool_json->append("\n... [TRUNCATED]"); : } : : / > Done Done http://gerrit.cloudera.org:8080/#/c/24284/4/be/src/service/query-profile-ai-analysis.cc@308 PS4, Line 308: static Status BuildAgentPayloadJson( : const vector<ChatMessage>& conversation, string* payload_json) { : if (payload_json == nullptr) return Status("payload output pointer cannot be null"); : : Document tools_doc; : > Done Done http://gerrit.cloudera.org:8080/#/c/24284/4/be/src/service/query-profile-ai-analysis.cc@387 PS4, Line 387: if (ctx == nullptr) { > Done Done http://gerrit.cloudera.org:8080/#/c/24284/4/be/src/service/query-profile-ai-analysis.cc@512 PS4, Line 512: LOG(WARNING) << "Tool call '" << tool_name << "' failed: " : << tool_status.GetDetail(); : Document tool_error_doc; : tool_error_doc.SetObject(); : > Added logic to let the model know through conversation that it passed us a Done http://gerrit.cloudera.org:8080/#/c/24284/4/be/src/service/query-profile-ai-analysis.cc@570 PS4, Line 570: RN_IF_ERROR(RunAiAgentW > Done Done -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 6 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 14 May 2026 21:38:46 +0000 Gerrit-HasComments: Yes
