Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 6: -Code-Review (1 comment) http://gerrit.cloudera.org:8080/#/c/24284/6/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/24284/6/be/src/service/impala-http-handler.cc@481 PS6, Line 481: status = GenerateAiAnalysisFromProfile( : string(profile_buffer.GetString(), profile_buffer.GetSize()), &analysis); The linker is failing on this line with: ../../build/release/service/libService.so: error: undefined reference to 'impala::GenerateAiAnalysisFromProfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*)' clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation) I believe the issue is related to GenerateAiAnalysisFromProfile needing a const string reference as the first parameter, but it's not able to cast the return from the string constructor to a constant because it's unnamed. I think the best fix is to modify GenerateAiAnalysisFromProfile to accept a string_view and modify line 482 to construct a string_view instead of a string. -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 6 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 14 May 2026 21:54:28 +0000 Gerrit-HasComments: Yes
