Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 7: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.h File be/src/service/query-profile-ai-analysis.h: http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.h@36 PS7, Line 36: Status GenerateAiAnalysisFromProfile(std::string_view profile_text, std::string* analysis); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.cc File be/src/service/query-profile-ai-analysis.cc: http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.cc@319 PS7, Line 319: json_value.SetString(value.data(), static_cast<rapidjson::SizeType>(value.size()), alloc); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.cc@537 PS7, Line 537: .append("' was ignored because tool_call id was missing. Retry with a valid " line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24284/7/be/src/service/query-profile-ai-analysis.cc@623 PS7, Line 623: tool_doc.AddMember("tool_name", MakeJsonStringValue(tool_name, tool_doc.GetAllocator()), line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 7 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 16 May 2026 00:10:04 +0000 Gerrit-HasComments: Yes
