Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24283 )
Change subject: IMPALA-14962: Query Profile Parser and Section Retrieval Interface ...................................................................... Patch Set 14: (17 comments) http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc File be/src/service/query-profile-parsing-tools.cc: http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc@366 PS13, Line 366: Document::AllocatorType& alloc) const { : const Value* scoped = GetScopedExecutionProfile(); > Done Done http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc@455 PS13, Line 455: const pair<string, const Value*>* rhs) const { > Done Done http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc@481 PS13, Line 481: ll > Done Done http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc@486 PS13, Line 486: if (!fragment.IsObject()) return; : for (auto it = fragment.MemberBegin(); it != fragment.MemberEnd(); ++it) { > Done Done http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc@515 PS13, Line 515: Value QueryProfileToolAccessor::GetOperator(string_view node_id, string_view fragment_id, > Done Done http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc@527 PS13, Line 527: er > Done Done http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc@554 PS13, Line 554: const Value* match = SearchOperator(*fragment.second, node_id, &node_key); > Done Done http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc@670 PS13, Line 670: : for (const auto& fragment : fragments_) { : vector<pair<string_view, const Value*>> nodes; : FindNodesByPattern(*fragment.second, "SCAN", &nodes); : for (const auto& node : nodes) { : > Done Done http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc@986 PS13, Line 986: const Value& data, vector<pair<string, const Value*>>* out) const { > Done Done http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc@1314 PS13, Line 1314: fragment_id = string_view( > Done Done http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc@1324 PS13, Line 1324: string_view fragment_id; > Done Done http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc@1328 PS13, Line 1328: args["node_id"].GetString(), args["node_id"].GetStringLength()); > Done Done http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc@1339 PS13, Line 1339: if (args.HasMember("instance_id") && args["instance_id"].IsString()) { > Done Done http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc@1343 PS13, Line 1343: return Status( > Done Done http://gerrit.cloudera.org:8080/#/c/24283/13/be/src/service/query-profile-parsing-tools.cc@1347 PS13, Line 1347: return Status::OK(); > Done Done http://gerrit.cloudera.org:8080/#/c/24283/14/be/src/service/query-profile-parsing-tools.cc File be/src/service/query-profile-parsing-tools.cc: http://gerrit.cloudera.org:8080/#/c/24283/14/be/src/service/query-profile-parsing-tools.cc@343 PS14, Line 343: fragments_.emplace(move(entry.second)); fragments_ is now a set, but it does not have the custom sorting function from patch 13. Is that the intended behavior? https://gerrit.cloudera.org/c/24283/13..14/be/src/service/query-profile-parsing-tools.cc#b366 http://gerrit.cloudera.org:8080/#/c/24283/14/be/src/service/query-profile-parsing-tools.cc@453 PS14, Line 453: struct FragmentPtrLess { : bool operator()(const pair<string, const Value*>* lhs, : const pair<string, const Value*>* rhs) const { : if (lhs->first != rhs->first) return lhs->first < rhs->first; : return lhs < rhs; : } : }; Define this struct in the private section of the QueryProfileToolAccessor class definition in query-profile-parsing-tools.h -- To view, visit http://gerrit.cloudera.org:8080/24283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d9c9e735aa089bb243b07af421553002a465a88 Gerrit-Change-Number: 24283 Gerrit-PatchSet: 14 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2026 04:20:18 +0000 Gerrit-HasComments: Yes
