Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24358 )
Change subject: IMPALA-12955: Slim down profile tool deps ...................................................................... Patch Set 6: (1 comment) > Patch Set 5: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/24358/4/be/src/util/runtime-profile-archive.cc File be/src/util/runtime-profile-archive.cc: http://gerrit.cloudera.org:8080/#/c/24358/4/be/src/util/runtime-profile-archive.cc@166 PS4, Line 166: const std::string& archive_str, TRuntimeProfileTree* out) { > I'd prefer refactors like this to be split out in a separate patch given so Agreed, this is a fair point. I split the mechanical RuntimeProfile source move into prerequisite change 24381 and rebased this change on top of it. PS6 has the same final source tree as PS5, but the RuntimeProfile move should now be reviewable separately from the profile-tool linking and dependency changes. -- To view, visit http://gerrit.cloudera.org:8080/24358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id476411dcf6c46079e2e2addc5cdd552bc23f8a1 Gerrit-Change-Number: 24358 Gerrit-PatchSet: 6 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 29 May 2026 20:03:25 +0000 Gerrit-HasComments: Yes
