Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24342 )
Change subject: IMPALA-14976: Add optional Kudu Helm resources ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/24342/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24342/2//COMMIT_MSG@15 PS2, Line 15: Testing: Add details here if this change was manually tested by spinning up a K8s cluster with Kudu support. If not, please do that testing. Also, be sure to note if the testing was local (e.g. using Minikube) or another cloud-based multi-node setup. http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-master-deployment.yaml File helm/impala/templates/kudu-master-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-master-deployment.yaml@72 PS2, Line 72: containerPort: {{ .Values.kudu.master.webPort | default 8051 }} With the StatefulSet having a ClusterIP Service pointing to it, port 8051 will be load balanced across instances. Would it be better to increment each replica's web port by 1 (e.g. replica 1 is port 8051, replica 2 is port 8052, etc) or will accessing the web ui on one master server give all information needed by the admins and allow them to access the web ui on other master servers using the pod IP addresses? I'm leaning towards leaving the configuration as it is for simplicity's sake. http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-pvc.yaml File helm/impala/templates/kudu-pvc.yaml: http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-pvc.yaml@34 PS2, Line 34: ReadWriteOnce Will this have the same issue described at https://gerrit.cloudera.org/c/24313/10/helm/impala/values.yaml#29? http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-pvc.yaml@57 PS2, Line 57: ReadWriteOnce Same question as line 34. http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-tserver-deployment.yaml File helm/impala/templates/kudu-tserver-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-tserver-deployment.yaml@73 PS2, Line 73: containerPort: {{ .Values.kudu.tserver.webPort | default 8050 }} Same question as the master server web port. Since the master servers use port 8051, either the table or master servers would need to start at a different port number. -- To view, visit http://gerrit.cloudera.org:8080/24342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50671c46bbc30beb9d643880910adbd3f77407b6 Gerrit-Change-Number: 24342 Gerrit-PatchSet: 2 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Thu, 28 May 2026 19:41:53 +0000 Gerrit-HasComments: Yes
