Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24342 )
Change subject: IMPALA-14976: Add optional Kudu Helm resources ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/24342/10/helm/impala/templates/kudu-master-deployment.yaml File helm/impala/templates/kudu-master-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24342/10/helm/impala/templates/kudu-master-deployment.yaml@30 PS10, Line 30: replicas: {{ .Values.kudu.master.replicas | default 1 }} Even if replicas is intentionally set to 0 here, helm will fallback to the default of 1. http://gerrit.cloudera.org:8080/#/c/24342/10/helm/impala/templates/kudu-tserver-deployment.yaml File helm/impala/templates/kudu-tserver-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24342/10/helm/impala/templates/kudu-tserver-deployment.yaml@30 PS10, Line 30: replicas: {{ .Values.kudu.tserver.replicas | default 1 }} Even if replicas is intentionally set to 0 here, helm will fallback to the default of 1. http://gerrit.cloudera.org:8080/#/c/24342/10/helm/impala/templates/kudu-validation.yaml File helm/impala/templates/kudu-validation.yaml: http://gerrit.cloudera.org:8080/#/c/24342/10/helm/impala/templates/kudu-validation.yaml@21 PS10, Line 21: {{- if ne (int (.Values.kudu.master.replicas | default 1)) 1 }} I believe we are trying to enforce a replica count of 1 here, but an edge case is that if replica count is set to 0, helm will fallback to the default of 1 and the validation will fail to reject it. http://gerrit.cloudera.org:8080/#/c/24342/10/helm/impala/templates/kudu-validation.yaml@24 PS10, Line 24: {{- if ne (int (.Values.kudu.tserver.replicas | default 1)) 1 }} I believe we are trying to enforce a replica count of 1 here, but an edge case is that if replica count is set to 0, helm will fallback to the default of 1 and the validation will fail to reject it. -- To view, visit http://gerrit.cloudera.org:8080/24342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50671c46bbc30beb9d643880910adbd3f77407b6 Gerrit-Change-Number: 24342 Gerrit-PatchSet: 10 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Tue, 02 Jun 2026 21:35:08 +0000 Gerrit-HasComments: Yes
