Anubhav Jindal has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24342 )

Change subject: IMPALA-14976: Add optional Kudu Helm resources
......................................................................


Patch Set 6:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/24342/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24342/2//COMMIT_MSG@15
PS2, Line 15: Testing:
> Add details here if this change was manually tested by spinning up a K8s cl
Thanks, agreed. I will update the commit message Testing section with explicit 
manual K8s validation details.


http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-master-deployment.yaml
File helm/impala/templates/kudu-master-deployment.yaml:

http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-master-deployment.yaml@72
PS2, Line 72:               containerPort: {{ .Values.kudu.master.webPort | 
default 8051 }}
> With the StatefulSet having a ClusterIP Service pointing to it, port 8051 w
Good point. For this change I am scoping Kudu support to a single-replica 
baseline (master/tserver replicas=1). In that scope, keeping fixed web ports is 
sufficient and avoids introducing premature HA behavior.


http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-pvc.yaml
File helm/impala/templates/kudu-pvc.yaml:

http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-pvc.yaml@34
PS2, Line 34: ReadWriteOnce
> Will this have the same issue described at https://gerrit.cloudera.org/c/24
Yes. With replicas >1 this can run into multi-attach constraints. I will make 
the scope explicit by enforcing single-replica Kudu in chart validation for 
this PR, so this PVC model remains correct for the supported configuration.


http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-tserver-deployment.yaml
File helm/impala/templates/kudu-tserver-deployment.yaml:

http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-tserver-deployment.yaml@73
PS2, Line 73:               containerPort: {{ .Values.kudu.tserver.webPort | 
default 8050 }}
> Same question as the master server web port.  Since the master servers use
Same resolution here: I will enforce single-replica Kudu in this PR so the 
current PVC model is valid for supported usage



--
To view, visit http://gerrit.cloudera.org:8080/24342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50671c46bbc30beb9d643880910adbd3f77407b6
Gerrit-Change-Number: 24342
Gerrit-PatchSet: 6
Gerrit-Owner: Anubhav Jindal <[email protected]>
Gerrit-Reviewer: Anubhav Jindal <[email protected]>
Gerrit-Reviewer: Gokul Kolady <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Comment-Date: Fri, 29 May 2026 08:40:24 +0000
Gerrit-HasComments: Yes

Reply via email to