Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24342 )
Change subject: IMPALA-14976: Add optional Kudu Helm resources ...................................................................... Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/24342/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24342/2//COMMIT_MSG@15 PS2, Line 15: with the current storage and service model. > Thanks, agreed. I will update the commit message Testing section with expli Done http://gerrit.cloudera.org:8080/#/c/24342/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24342/10//COMMIT_MSG@36 PS10, Line 36: Co-authored-by: Cursor <[email protected]> For now, please add "Generated-by: Cursor (model name)" to this commit message. See these instructions for details: https://www.apache.org/legal/generative-tooling.html#:~:text=This%20should%20be%20included%20as%20a%20token%20in%20the%20source%20control%20commit%20message%2C%20for%20example%20including%20the%20phrase%20%E2%80%9CGenerated%2Dby%3A%20%E2%80%9D http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-master-deployment.yaml File helm/impala/templates/kudu-master-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-master-deployment.yaml@72 PS2, Line 72: containerPort: {{ .Values.kudu.master.webPort | default 8051 }} > Good point. For this change I am scoping Kudu support to a single-replica b Done. That's a good approach to limit Kudu to single-replica. http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-pvc.yaml File helm/impala/templates/kudu-pvc.yaml: http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-pvc.yaml@34 PS2, Line 34: ReadWriteOnce > Yes. With replicas >1 this can run into multi-attach constraints. I will ma Done http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-pvc.yaml@57 PS2, Line 57: ReadWriteOnce > Yes. With replicas >1 this can run into multi-attach constraints. I will ma Done http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-tserver-deployment.yaml File helm/impala/templates/kudu-tserver-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24342/2/helm/impala/templates/kudu-tserver-deployment.yaml@73 PS2, Line 73: containerPort: {{ .Values.kudu.tserver.webPort | default 8050 }} > Same resolution here: I will enforce single-replica Kudu in this PR so the Done. That's a good approach to limit Kudu to single-replica. -- To view, visit http://gerrit.cloudera.org:8080/24342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50671c46bbc30beb9d643880910adbd3f77407b6 Gerrit-Change-Number: 24342 Gerrit-PatchSet: 10 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Fri, 29 May 2026 17:39:05 +0000 Gerrit-HasComments: Yes
