Anubhav Jindal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24313 )
Change subject: IMPALA-14974: Add Helm chart scaffold for core Impala services on Kubernetes ...................................................................... Patch Set 11: (2 comments) Addressed the review comments. http://gerrit.cloudera.org:8080/#/c/24313/10/helm/impala/templates/impalad-deployment.yaml File helm/impala/templates/impalad-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24313/10/helm/impala/templates/impalad-deployment.yaml@77 PS10, Line 77: server_name > This needs to be server_name Thanks for pointing this out, I have changed it in next revision. http://gerrit.cloudera.org:8080/#/c/24313/10/helm/impala/values.yaml File helm/impala/values.yaml: http://gerrit.cloudera.org:8080/#/c/24313/10/helm/impala/values.yaml@29 PS10, Line 29: # Default to ReadWriteMany for multi-node scheduling compatibility. > Good catch! We should support multi-node clusters and not assume a single Thank you Gokul. This is a very valid and good catch. I fixed it in the next revision. -- To view, visit http://gerrit.cloudera.org:8080/24313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie203b8528e193f320613c1c208d098908d76ed0b Gerrit-Change-Number: 24313 Gerrit-PatchSet: 11 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Thu, 28 May 2026 21:25:36 +0000 Gerrit-HasComments: Yes
