Anubhav Jindal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24313 )
Change subject: IMPALA-14974: Add Helm chart scaffold for core Impala services on Kubernetes ...................................................................... Patch Set 16: (6 comments) Done http://gerrit.cloudera.org:8080/#/c/24313/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24313/15//COMMIT_MSG@29 PS15, Line 29: > For now, please add "Generated-by: Cursor (model name)" to this commit mess Done http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/templates/catalogd-deployment.yaml File helm/impala/templates/catalogd-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/templates/catalogd-deployment.yaml@59 PS15, Line 59: - -v={{ .Values.catalogd.v }} > If the user tries to set debug level to 0 helm will fallback to the default Done http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/templates/impalad-deployment.yaml File helm/impala/templates/impalad-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/templates/impalad-deployment.yaml@57 PS15, Line 57: - -v={{ .Values.impalad.v }} > If the user tries to set debug level to 0 helm will fallback to the default Done http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/templates/impalad-deployment.yaml@79 PS15, Line 79: - -mt_dop_auto_fallback={{ .Values.impalad.mtDopAutoFallback }} > I believe this is problematic because even if the user explicitly sets fals Done http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/templates/statestored-deployment.yaml File helm/impala/templates/statestored-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/templates/statestored-deployment.yaml@59 PS15, Line 59: - -v={{ .Values.statestored.v }} > If the user tries to set debug level to 0 helm will fallback to the default Done http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/values.yaml File helm/impala/values.yaml: http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/values.yaml@30 PS15, Line 30: # If your cluster does not provide RWX-capable storage classes, override : # this one list to ReadWriteOnce and co-locate dependent pods on on > Is this a common case where clusters do not provide RWX-capable storage cla For core services in this change, there is only one shared warehouse PVC access mode (persistence.accessModes), so users can switch with one override. I have clarified this in docs/comments and added an explicit example override for single-node clusters. -- To view, visit http://gerrit.cloudera.org:8080/24313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie203b8528e193f320613c1c208d098908d76ed0b Gerrit-Change-Number: 24313 Gerrit-PatchSet: 16 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Wed, 03 Jun 2026 22:07:45 +0000 Gerrit-HasComments: Yes
