Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24313 )
Change subject: IMPALA-14974: Add Helm chart scaffold for core Impala services on Kubernetes ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/24313/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24313/15//COMMIT_MSG@29 PS15, Line 29: Implemented and validated manually; Cursor-assisted. For now, please add "Generated-by: Cursor (model name)" to this commit message. See these instructions for details: https://www.apache.org/legal/generative-tooling.html#:~:text=This%20should%20be%20included%20as%20a%20token%20in%20the%20source%20control%20commit%20message%2C%20for%20example%20including%20the%20phrase%20%E2%80%9CGenerated%2Dby%3A%20%E2%80%9D http://gerrit.cloudera.org:8080/#/c/24313/10/helm/impala/templates/impalad-deployment.yaml File helm/impala/templates/impalad-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24313/10/helm/impala/templates/impalad-deployment.yaml@77 PS10, Line 77: server_name > Thanks for pointing this out, I have changed it in next revision. Done. Some examples places in the code use "server-name" which is incorrect. Opened IMPALA-15058 to address this. http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/values.yaml File helm/impala/values.yaml: http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/values.yaml@30 PS15, Line 30: # If your cluster does not provide RWX-capable storage classes, override this : # to ReadWriteOnce and co-locate the dependent pods on the same node. Is this a common case where clusters do not provide RWX-capable storage classes? If so, should we support a config parameter for running on single nodes that switches this accessMode to "ReadWriteOnce" so that users of these Helm charts do not need to update persistence accessModes in multiple places (not necessary if all volumes use this accessModes list)? -- To view, visit http://gerrit.cloudera.org:8080/24313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie203b8528e193f320613c1c208d098908d76ed0b Gerrit-Change-Number: 24313 Gerrit-PatchSet: 15 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Fri, 29 May 2026 17:30:24 +0000 Gerrit-HasComments: Yes
