Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24313 )
Change subject: IMPALA-14974: Add Helm chart scaffold for core Impala services on Kubernetes ...................................................................... Patch Set 15: (5 comments) http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/templates/catalogd-deployment.yaml File helm/impala/templates/catalogd-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/templates/catalogd-deployment.yaml@59 PS15, Line 59: - -v={{ .Values.catalogd.v | default 1 }} If the user tries to set debug level to 0 helm will fallback to the default value of 1, making it impossible for a user to set the level to 0. http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/templates/impalad-deployment.yaml File helm/impala/templates/impalad-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/templates/impalad-deployment.yaml@57 PS15, Line 57: - -v={{ .Values.impalad.v | default 1 }} If the user tries to set debug level to 0 helm will fallback to the default value of 1, making it impossible for a user to set the level to 0. http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/templates/impalad-deployment.yaml@79 PS15, Line 79: - -mt_dop_auto_fallback={{ .Values.impalad.mtDopAutoFallback | default true }} I believe this is problematic because even if the user explicitly sets false it would trigger a fallback to the default true value. This makes it impossible for a user to ever set this to false. http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/templates/statestored-deployment.yaml File helm/impala/templates/statestored-deployment.yaml: http://gerrit.cloudera.org:8080/#/c/24313/15/helm/impala/templates/statestored-deployment.yaml@59 PS15, Line 59: - -v={{ .Values.statestored.v | default 1 }} If the user tries to set debug level to 0 helm will fallback to the default value of 1, making it impossible for a user to set the level to 0. http://gerrit.cloudera.org:8080/#/c/24313/10/helm/impala/values.yaml File helm/impala/values.yaml: http://gerrit.cloudera.org:8080/#/c/24313/10/helm/impala/values.yaml@29 PS10, Line 29: # Default to ReadWriteMany for multi-node scheduling compatibility. > persistence.accessModes defaults to ReadWriteOnce, but this same -warehouse Done -- To view, visit http://gerrit.cloudera.org:8080/24313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie203b8528e193f320613c1c208d098908d76ed0b Gerrit-Change-Number: 24313 Gerrit-PatchSet: 15 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Tue, 02 Jun 2026 21:21:21 +0000 Gerrit-HasComments: Yes
