Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24358 )
Change subject: IMPALA-12955: Slim down profile tool deps ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/24358/7/be/src/util/runtime-profile-archive.cc File be/src/util/runtime-profile-archive.cc: http://gerrit.cloudera.org:8080/#/c/24358/7/be/src/util/runtime-profile-archive.cc@88 PS7, Line 88: // Match Base64DecodeBufLen()'s length validation without linking coding-util.cc Done in PS5. Added a comment explaining that the local length check mirrors Base64DecodeBufLen() while avoiding the coding-util.cc dependency. http://gerrit.cloudera.org:8080/#/c/24358/7/be/src/util/runtime-profile-archive.cc@90 PS7, Line 90: if ((archive_str.size() & 3) != 0) { Done in PS5. The archive reader now reports invalid base64 length separately from invalid base64 data. http://gerrit.cloudera.org:8080/#/c/24358/7/be/src/util/runtime-profile-archive.cc@166 PS7, Line 166: const std::string& archive_str, TRuntimeProfileTree* out) { Done. The RuntimeProfile source split is now separated into prerequisite change 24381, and this dependency-reduction change is stacked on top of it. PS7 keeps the same split shape and the current commit message describes the non-mechanical archive-reader changes. -- To view, visit http://gerrit.cloudera.org:8080/24358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id476411dcf6c46079e2e2addc5cdd552bc23f8a1 Gerrit-Change-Number: 24358 Gerrit-PatchSet: 7 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 01 Jun 2026 12:36:59 +0000 Gerrit-HasComments: Yes
