Aleksandr Efimov has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24358 )

Change subject: IMPALA-12955: Slim down profile tool deps
......................................................................


Patch Set 7:

(1 comment)

> Patch Set 6:
>
> (1 comment)

http://gerrit.cloudera.org:8080/#/c/24358/6/be/src/util/cpu-info.cc
File be/src/util/cpu-info.cc:

http://gerrit.cloudera.org:8080/#/c/24358/6/be/src/util/cpu-info.cc@260
PS6, Line 260:     return Status("This machine does not meet the minimum 
requirements for Impala "
> Why did these change to Expected?
Done. This was leftover from the earlier link split. With the current
ProfileToolCommon shape, the profile tool links status.cc and StackTraceUtil,
so the regular Status(string) constructor is available again. I reverted these
back to the original Status(...) constructors in PS7.



--
To view, visit http://gerrit.cloudera.org:8080/24358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id476411dcf6c46079e2e2addc5cdd552bc23f8a1
Gerrit-Change-Number: 24358
Gerrit-PatchSet: 7
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Fri, 29 May 2026 21:43:55 +0000
Gerrit-HasComments: Yes

Reply via email to