Hello Quanlong Huang, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24358
to look at the new patch set (#7).
Change subject: IMPALA-12955: Slim down profile tool deps
......................................................................
IMPALA-12955: Slim down profile tool deps
Use the RuntimeProfile source split from the parent change to link
impala-profile-tool against smaller dependency subsets. The tool no
longer pulls in unused runtime libraries such as HDFS, JVM, Kudu,
SASL, Kerberos, SSL, and crypto dependencies.
The profile tool now links a smaller thrift library, ProfileToolUtil,
and ProfileToolCommon. Keep CMake source lists shared with the full
targets to avoid drift.
Move GetStackTrace() into common/stack-trace.* so Common and
ProfileToolCommon can share it without linking debug-util.cc. Move
Status thrift/proto/HS2 conversions out of the Status class into
status-serialization.* free functions.
The archive reader uses local base64 length validation, base64
unescaping, zlib inflate, and local thrift deserialization to avoid
pulling coding-util.cc and thrift-util.cc dependencies into the
profile tool. Error messages distinguish invalid base64 length from
invalid base64 data.
The Linux dependency test checks both direct NEEDED entries and
transitive ldd output so regressions through shared helper libraries
are caught.
Tests:
- git diff --check
- python3 -m py_compile
tests/observability/test_profile_tool_dependencies.py
- python3 bin/jenkins/critique-gerrit-review.py --dryrun
- Kubernetes job impala-source-build-12955-ps7g:
./buildall.sh -notests -noclean -cmake_only
make -C be/src/util impala-profile-tool -j 64
bin/create-test-configuration.sh
bin/impala-py.test -q tests/observability/test_profile_tool.py
Assisted-by: OpenAI Codex
Change-Id: Id476411dcf6c46079e2e2addc5cdd552bc23f8a1
---
M be/generated-sources/gen-cpp/CMakeLists.txt
M be/src/catalog/catalog-server.cc
M be/src/catalog/workload-management-init.cc
M be/src/common/CMakeLists.txt
A be/src/common/stack-trace.cc
A be/src/common/stack-trace.h
A be/src/common/status-serialization.cc
A be/src/common/status-serialization.h
M be/src/common/status.cc
M be/src/common/status.h
M be/src/exec/catalog-op-executor.cc
M be/src/exec/data-source-scan-node.cc
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/krpc-data-stream-sender.cc
M be/src/runtime/mem-pool.h
M be/src/runtime/query-state.cc
M be/src/runtime/runtime-filter-bank.cc
A be/src/runtime/summary-stats.h
M be/src/scheduling/admission-control-service.cc
M be/src/scheduling/remote-admission-control-client.cc
M be/src/service/child-query.cc
M be/src/service/client-request-state.cc
M be/src/service/control-service.cc
M be/src/service/data-stream-service.cc
M be/src/service/fe-support.cc
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-server.cc
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore.cc
M be/src/util/CMakeLists.txt
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
A be/src/util/error-msg.cc
M be/src/util/error-util.cc
M be/src/util/runtime-profile-archive.cc
M be/src/util/runtime-profile.cc
A tests/observability/test_profile_tool_dependencies.py
37 files changed, 753 insertions(+), 417 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/24358/7
--
To view, visit http://gerrit.cloudera.org:8080/24358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id476411dcf6c46079e2e2addc5cdd552bc23f8a1
Gerrit-Change-Number: 24358
Gerrit-PatchSet: 7
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
