Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24401 )
Change subject: IMPALA-14702 (prep): Add an abstraction around malloc implementation details ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/24401/1/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24401/1/be/CMakeLists.txt@756 PS1, Line 756: set (UNIFIED_TEST_LINK_LIBS "${IMPALA_LINK_LIBS}" MallocUtilSanitizer) > Bug: Needs to use UNIFIED_TEST_LINK_LIBS Done http://gerrit.cloudera.org:8080/#/c/24401/1/be/src/util/malloc-util-gperftools.h File be/src/util/malloc-util-gperftools.h: http://gerrit.cloudera.org:8080/#/c/24401/1/be/src/util/malloc-util-gperftools.h@105 PS1, Line 105: return metrics->RegisterMetric(new TcmallocMetric(MetricDefs::Get(key), tcmalloc_var)); > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/24401/1/be/src/util/malloc-util-gperftools.h@166 PS1, Line 166: << FLAGS_tcmalloc_max_total_thread_cache_bytes << " bytes but actually " > line too long (91 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/24401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ac7841cf279ac40141147d4be9192894d6dc908 Gerrit-Change-Number: 24401 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Thu, 04 Jun 2026 21:13:39 +0000 Gerrit-HasComments: Yes
