Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24401 )
Change subject: IMPALA-14702 (prep): Add an abstraction around malloc implementation details ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24401/2/be/src/runtime/test-env.cc File be/src/runtime/test-env.cc: http://gerrit.cloudera.org:8080/#/c/24401/2/be/src/runtime/test-env.cc@75 PS2, Line 75: } else { : RETURN_IF_ERROR(tmp_file_mgr()->Init(metrics())); : } > This needs to move earlier, before RegisterMemoryMetrics() above. Done http://gerrit.cloudera.org:8080/#/c/24401/3/be/src/util/metrics-test.cc File be/src/util/metrics-test.cc: http://gerrit.cloudera.org:8080/#/c/24401/3/be/src/util/metrics-test.cc@254 PS3, Line 254: ASSERT_OK(MallocUtil::GetInstance()->Init(/*process_mem_limit*/ -1)); Wrong signature, Init() takes no arguments at this point. -- To view, visit http://gerrit.cloudera.org:8080/24401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ac7841cf279ac40141147d4be9192894d6dc908 Gerrit-Change-Number: 24401 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 07:11:48 +0000 Gerrit-HasComments: Yes
