Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24401 )
Change subject: IMPALA-14702 (prep): Add an abstraction around malloc implementation details ...................................................................... Patch Set 4: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/24401/2/be/src/runtime/bufferpool/system-allocator.cc File be/src/runtime/bufferpool/system-allocator.cc: http://gerrit.cloudera.org:8080/#/c/24401/2/be/src/runtime/bufferpool/system-allocator.cc@51 PS2, Line 51: CHECK_EQ(support, MallocUtil::HugePageSupport::MADVISE_COMPATIBLE); > Got it working. I needed to add an operator<< function for MallocUtil::Huge Done http://gerrit.cloudera.org:8080/#/c/24401/2/be/src/util/malloc-util.h File be/src/util/malloc-util.h: http://gerrit.cloudera.org:8080/#/c/24401/2/be/src/util/malloc-util.h@32 PS2, Line 32: > I changed this to initialize it during GetInstance(), so there is no need f Ack http://gerrit.cloudera.org:8080/#/c/24401/2/be/src/util/malloc-util.h@37 PS2, Line 37: > Done Ack -- To view, visit http://gerrit.cloudera.org:8080/24401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ac7841cf279ac40141147d4be9192894d6dc908 Gerrit-Change-Number: 24401 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 18:04:58 +0000 Gerrit-HasComments: Yes
