Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24401 )
Change subject: IMPALA-14702 (prep): Add an abstraction around malloc implementation details ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/24401/2/be/src/util/malloc-util-gperftools.h File be/src/util/malloc-util-gperftools.h: http://gerrit.cloudera.org:8080/#/c/24401/2/be/src/util/malloc-util-gperftools.h@110 PS2, Line 110: int64_t retval; The old code used zero init. http://gerrit.cloudera.org:8080/#/c/24401/2/be/src/util/malloc-util.cc File be/src/util/malloc-util.cc: http://gerrit.cloudera.org:8080/#/c/24401/2/be/src/util/malloc-util.cc@48 PS2, Line 48: MallocUtil* MallocUtil::GetInstance() { Is it possible to eliminate Allocate by inlining it into GetInstance? http://gerrit.cloudera.org:8080/#/c/24401/2/be/src/util/pprof-path-handlers.cc File be/src/util/pprof-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/24401/2/be/src/util/pprof-path-handlers.cc@75 PS2, Line 75: delete profile; nit: free? -- To view, visit http://gerrit.cloudera.org:8080/24401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ac7841cf279ac40141147d4be9192894d6dc908 Gerrit-Change-Number: 24401 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 05 Jun 2026 08:33:17 +0000 Gerrit-HasComments: Yes
