Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24430 )

Change subject: IMPALA-15042: Use a clean environment for 
single_node_perf_run.py's subcommands
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24430/1/bin/single_node_perf_run.py
File bin/single_node_perf_run.py:

http://gerrit.cloudera.org:8080/#/c/24430/1/bin/single_node_perf_run.py@96
PS1, Line 96:   # Set env={} to use a clean environment. Existing environment 
variables can cause
            :   # complicated interactions. For example, this script runs with 
impala-python3,
            :   # which sets LD_LIBRARY_PATH to use the toolchain libstdc++. On 
newer OSes, this
            :   # can cause issues for system binaries that need to use a newer 
libstdc++.
            :   return subprocess.check_call(["bash", "-c", cmd], env={})
This call is used for Impala's buildall.sh, loading data, etc, so it will no 
longer inherit environment variables. That might be unexpected. I'm testing 
bin/impala-config-local.sh to see if that is a workaround.



--
To view, visit http://gerrit.cloudera.org:8080/24430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I984b094be73b185ab151d5d1ba51602b7083d22a
Gerrit-Change-Number: 24430
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Tue, 09 Jun 2026 22:50:01 +0000
Gerrit-HasComments: Yes

Reply via email to