Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24430 )

Change subject: IMPALA-15042: Use a clean environment for 
single_node_perf_run.py's subcommands
......................................................................


Patch Set 2: Code-Review+2

> Patch Set 2:
>
> (1 comment)
>
> This does change the behavior, so we need to be careful. I think it is easier 
> to reason about the system when it uses a clean environment. If this makes 
> sense, I will change our jobs to put the variables in 
> bin/impala-config-local.sh (which works fine).

Makes sense to me. https://jenkins.impala.io/job/perf-AB-test-ub2004 has a few 
variables that will need to be moved.


--
To view, visit http://gerrit.cloudera.org:8080/24430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I984b094be73b185ab151d5d1ba51602b7083d22a
Gerrit-Change-Number: 24430
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Wed, 10 Jun 2026 15:40:17 +0000
Gerrit-HasComments: No

Reply via email to