Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24430
to look at the new patch set (#2).
Change subject: IMPALA-15042: Use a clean environment for
single_node_perf_run.py's subcommands
......................................................................
IMPALA-15042: Use a clean environment for single_node_perf_run.py's subcommands
bin/single_node_perf_run.py runs complicated things including
a whole build using Python subprocess. This is currently inheriting
environment variables, which can cause complicated interactions.
For example, single_node_perf_run.py uses impala-python3, which
sets LD_LIBRARY_PATH to point to the toolchain libstdc++. For
newer platforms (e.g. Ubuntu 22), this can cause issues for system
binaries like ccache that need a newer libstdc++. This can also
cause issues with stuck variables when switching back and forth
between the A and B git branches and sourcing bin/impala-config.sh.
This changes bin/single_node_perf_run.py to use a clean environment
for most subprocess invocations. This is a change in behavior as
it previously respected the variables in the environment. Users can
achieve the same impact by putting their environment variables in
bin/impala-config-local.sh.
Testing:
- Ran a perf-AB-test job with Ubuntu 22 (which was previously
failing)
Change-Id: I984b094be73b185ab151d5d1ba51602b7083d22a
---
M bin/single_node_perf_run.py
1 file changed, 13 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/24430/2
--
To view, visit http://gerrit.cloudera.org:8080/24430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I984b094be73b185ab151d5d1ba51602b7083d22a
Gerrit-Change-Number: 24430
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
