Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24430 )
Change subject: IMPALA-15042: Use a clean environment for single_node_perf_run.py's subcommands ...................................................................... Patch Set 2: (1 comment) This does change the behavior, so we need to be careful. I think it is easier to reason about the system when it uses a clean environment. If this makes sense, I will change our jobs to put the variables in bin/impala-config-local.sh (which works fine). http://gerrit.cloudera.org:8080/#/c/24430/1/bin/single_node_perf_run.py File bin/single_node_perf_run.py: http://gerrit.cloudera.org:8080/#/c/24430/1/bin/single_node_perf_run.py@96 PS1, Line 96: if type(cmd) is list: : cmd = " ".join([pipes.quote(arg) for arg in cmd]) : cmd = "source {0}/bin/impala-config.sh && {1}".format(IMPALA_HOME, cmd) : # Set env={} to use a clean environment. Existing environment variables can cause : # complicated interactions. For example, this script runs > This call is used for Impala's buildall.sh, loading data, etc, so it will n bin/impala-config-local.sh works fine. -- To view, visit http://gerrit.cloudera.org:8080/24430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I984b094be73b185ab151d5d1ba51602b7083d22a Gerrit-Change-Number: 24430 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 10 Jun 2026 00:34:00 +0000 Gerrit-HasComments: Yes
