Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24429 )
Change subject: IMPALA-15090: Make Query Profile Redaction DOM to DOM ...................................................................... Patch Set 4: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24429/4/be/src/service/query-profile-redaction-test.cc File be/src/service/query-profile-redaction-test.cc: http://gerrit.cloudera.org:8080/#/c/24429/4/be/src/service/query-profile-redaction-test.cc@316 PS4, Line 316: const std::vector<string> values = test::CollectStringValuesFromJsonForTest(profile_json); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24429/4/be/src/service/query-profile-redaction-test.cc@331 PS4, Line 331: const std::vector<string> email_matches = test::CollectRegexMatchesFromTextsForTest(texts, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24429/4/be/src/service/query-profile-redaction-test.cc@347 PS4, Line 347: const std::vector<string> ipv6_matches = test::CollectIpv6MatchesFromTextsForTest(texts); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b8ad721a5531e9d257cf6e54b83ea3ee9734039 Gerrit-Change-Number: 24429 Gerrit-PatchSet: 4 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 16 Jun 2026 01:36:41 +0000 Gerrit-HasComments: Yes
